From d2cf3a271cf94eac0cddf06adac7a57e68929b97 Mon Sep 17 00:00:00 2001 From: khen <30577427+khendrikse@users.noreply.github.com> Date: Fri, 6 Oct 2023 13:10:12 +0200 Subject: [PATCH] fix: remove snapshot test for Deploy plugin response syntax error --- .../build/tests/deploy/snapshots/tests.js.md | 52 ------------------ .../tests/deploy/snapshots/tests.js.snap | Bin 741 -> 658 bytes packages/build/tests/deploy/tests.js | 3 +- 3 files changed, 2 insertions(+), 53 deletions(-) diff --git a/packages/build/tests/deploy/snapshots/tests.js.md b/packages/build/tests/deploy/snapshots/tests.js.md index 8bb1ad0d92..a85e030a77 100644 --- a/packages/build/tests/deploy/snapshots/tests.js.md +++ b/packages/build/tests/deploy/snapshots/tests.js.md @@ -51,58 +51,6 @@ Generated by [AVA](https://avajs.dev). (Netlify Build completed in 1ms)␊ Build step duration: Netlify Build completed in 1ms` -## Deploy plugin response syntax error - -> Snapshot 1 - - `␊ - Netlify Build ␊ - ────────────────────────────────────────────────────────────────␊ - ␊ - > Version␊ - @netlify/build 1.0.0␊ - ␊ - > Flags␊ - buildbotServerSocket: /test/socket␊ - debug: true␊ - repositoryRoot: packages/build/tests/deploy/fixtures/empty␊ - testOpts:␊ - pluginsListUrl: test␊ - silentLingeringProcesses: true␊ - ␊ - > Current directory␊ - packages/build/tests/deploy/fixtures/empty␊ - ␊ - > Config file␊ - packages/build/tests/deploy/fixtures/empty/netlify.toml␊ - ␊ - > Resolved config␊ - build:␊ - publish: packages/build/tests/deploy/fixtures/empty␊ - publishOrigin: default␊ - ␊ - > Context␊ - production␊ - ␊ - Deploy site ␊ - ────────────────────────────────────────────────────────────────␊ - ␊ - ␊ - Internal error during "Deploy site" ␊ - ────────────────────────────────────────────────────────────────␊ - ␊ - Error message␊ - Invalid response from buildbot: SyntaxError: Unexpected token e in JSON at position 1␊ - ␊ - Error location␊ - During Deploy site␊ - STACK TRACE␊ - ␊ - Resolved config␊ - build:␊ - publish: packages/build/tests/deploy/fixtures/empty␊ - publishOrigin: default` - ## Deploy plugin response system error > Snapshot 1 diff --git a/packages/build/tests/deploy/snapshots/tests.js.snap b/packages/build/tests/deploy/snapshots/tests.js.snap index 045ad4f90dab0665287f4bbdc5e762aed074ce3e..15d3208b1007d026f4c1c1780308b55927c02359 100644 GIT binary patch literal 658 zcmV;D0&V?4RzVN*jlrG zfx8t;7axlV00000000B+mcee+Fc5|p&n-e4$~a@n-k91vw&Bt%6~w;*xM#*@^l z6Gt9<*}YNm3P_yGfmh+og)`zw7$@1)F3`eWD$z|8MY6}^*x!uj_eD0=COxC~pU^3% zak7tuy}P~e-0Ju4-Tu-SFVJa~&ESbw zTEe=I`0?T0fBg#a2wtNlWl90?xNK-dYuD{? z8aP$fNT0e8Y0;h+4h*iH^EV>vM`7m;Pk5V9Q!cz&nUWA_#?uvm z)*AZMl@r<$9GSN+?2<3+}2ey{LY~5@E00;HX3qC5GY4i3% z)TEM78aKaUx5sVa#<%jiUUSEO!)^(k7@h15pTo)V-tZu}Tw~79_2K>{`rrxerRwl` sMIAnN>d>h}rw$vK^`ePqdnIipVxtKBt`2{bg=@^*pYZrgUKJ7m04g0w-~a#s literal 741 zcmVK}^;00000000B+n7eKhK@^4qk%KfHJi#F}p^1}r3q){&6o?WOCrFgz-LuXp zvootXv&QZ~;t`OjL&2+1(@-Oxgfp|7i;0rpCKBr?2Rh z*Erh5QriiXx*942RHZ3mMv9Cq>BxHec#>t(%Xgihiwh4H!gH^)@bLckj@U)7RX%|i zmC_l^`iS43Km6ApA)diobfl~i0MAXWMt2a^SYKURT?;c_YB?kxkKF_7`{+jK`s@Pq z33NS@?^0~>qznhuFahr>85?(61i>?_A(Sd@Ok z#$j}?^puDocI{o-QREMuPU2`BAf?gx9c6~-`0I_cDH0(yhu{nJD(83#WXfS04#Rdc zoFuGZO|FKJ^Hww2b{k1oy)ATDXdlVy5oVCa6;D-du2>DUqN5pQIjPgo)%!F9Es8ni; zQX}{C3|KGdsi><4c`PBToDAY7aGipfrl_#E)Ka0PLQ94Di+ZumvN$7kT`5BO;mCpI3&JelZ3O_f;>`g~9%9aOq`~_6 zM*KTIR(S5%tku3Cw&)*h^j^ck{zh*rnA~EP+)NY(RB;tiI=`lf@}vEq(GsO4${a?0 zOO(q*X;{%nkTF|~^`|dwnsobb`0)4&K2(J6N;-U-qQjS#4lNy8I?Q3zi`t*fOO6H+ XbEUv#I^2YXTa4U4(Ns2bXBYqg!Dnn9 diff --git a/packages/build/tests/deploy/tests.js b/packages/build/tests/deploy/tests.js index fd5fa20bbf..93294ea989 100644 --- a/packages/build/tests/deploy/tests.js +++ b/packages/build/tests/deploy/tests.js @@ -50,7 +50,8 @@ test('Deploy plugin response syntax error', async (t) => { const { address, stopServer } = await startDeployServer({ response: 'test' }) try { const output = await new Fixture('./fixtures/empty').withFlags({ buildbotServerSocket: address }).runWithBuild() - t.snapshot(normalizeOutput(output)) + // This shape of this error can change with different Node.js versions. + t.true(output.includes('Invalid response from buildbot: SyntaxError: Unexpected token')) } finally { await stopServer() }