From 5c3f1705e600f7c281ac60b386774f31ca595af6 Mon Sep 17 00:00:00 2001 From: Philippe Serhal Date: Wed, 11 Dec 2024 11:55:22 -0500 Subject: [PATCH] ci: pin node.js major versions and let Renovate manage updates --- .github/workflows/benchmark.yml | 2 +- .github/workflows/pre-release.yml | 2 +- .github/workflows/workflow.yml | 17 +++++++++-------- 3 files changed, 11 insertions(+), 10 deletions(-) diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index 943150e49a..f3f3d11459 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -18,7 +18,7 @@ jobs: - name: Setup Node.js environment uses: actions/setup-node@v4 with: - node-version: '*' + node-version: '22' cache: 'npm' check-latest: true diff --git a/.github/workflows/pre-release.yml b/.github/workflows/pre-release.yml index 54977c40e1..638bf2a041 100644 --- a/.github/workflows/pre-release.yml +++ b/.github/workflows/pre-release.yml @@ -13,7 +13,7 @@ jobs: fetch-depth: 0 - uses: actions/setup-node@v4 with: - node-version: '*' + node-version: '22' check-latest: true registry-url: 'https://registry.npmjs.org' - name: Extract tag, version and package diff --git a/.github/workflows/workflow.yml b/.github/workflows/workflow.yml index d53600b0d8..536b9fdbaa 100644 --- a/.github/workflows/workflow.yml +++ b/.github/workflows/workflow.yml @@ -27,7 +27,7 @@ jobs: if: ${{ !steps.release-check.outputs.IS_RELEASE }} - uses: actions/setup-node@v4 with: - node-version: 18 + node-version: 22 if: ${{ !steps.release-check.outputs.IS_RELEASE }} - name: Install dependencies run: npm ci @@ -50,11 +50,12 @@ jobs: strategy: matrix: os: [ubuntu-24.04, macos-14, windows-2022] - node-version: ['*'] + node-version: ['22'] # Must include the minimum deno version from the `DENO_VERSION_RANGE` constant in `node/bridge.ts`. deno-version: ['v1.37.0', 'v1.44.4'] include: - os: ubuntu-24.04 + # Earliest supported version node-version: '14.16.0' deno-version: 'v1.44.4' fail-fast: false @@ -122,7 +123,7 @@ jobs: strategy: matrix: os: [ubuntu-24.04, macos-14, windows-2022] - node-version: ['*'] + node-version: ['22'] install-command: ['npm ci'] machine: ['0', '1', '2', '3', '4'] include: @@ -152,23 +153,23 @@ jobs: # But other consumers do not, like `npm install`. # So we test both. - os: ubuntu-24.04 - node-version: '*' + node-version: '22' install-command: npm install --no-package-lock machine: '0' - os: ubuntu-24.04 - node-version: '*' + node-version: '22' install-command: npm install --no-package-lock machine: '1' - os: ubuntu-24.04 - node-version: '*' + node-version: '22' install-command: npm install --no-package-lock machine: '2' - os: ubuntu-24.04 - node-version: '*' + node-version: '22' install-command: npm install --no-package-lock machine: '3' - os: ubuntu-24.04 - node-version: '*' + node-version: '22' install-command: npm install --no-package-lock machine: '4' fail-fast: false