From 4e97aa33d7fa041908fd2790dd02a518687eba78 Mon Sep 17 00:00:00 2001 From: Philippe Serhal Date: Wed, 11 Dec 2024 12:24:06 -0500 Subject: [PATCH] ci: remove the `--no-package-lock` tests These exist to test against fully updated dependencies and transitive dependencies, but this means that builds are not reproducible and even main can suddenly start failing without any code changes. Plus, Renovate is already our blessed, more controlled solution for this. --- .github/workflows/workflow.yml | 23 ----------------------- 1 file changed, 23 deletions(-) diff --git a/.github/workflows/workflow.yml b/.github/workflows/workflow.yml index bc94a7a980..24dc5e455a 100644 --- a/.github/workflows/workflow.yml +++ b/.github/workflows/workflow.yml @@ -148,29 +148,6 @@ jobs: node-version: '14.16.0' install-command: npm ci machine: '4' - # The buildbot pins Netlify Build's dependencies, like `npm ci`. - # But other consumers do not, like `npm install`. - # So we test both. - - os: ubuntu-latest - node-version: '*' - install-command: npm install --no-package-lock - machine: '0' - - os: ubuntu-latest - node-version: '*' - install-command: npm install --no-package-lock - machine: '1' - - os: ubuntu-latest - node-version: '*' - install-command: npm install --no-package-lock - machine: '2' - - os: ubuntu-latest - node-version: '*' - install-command: npm install --no-package-lock - machine: '3' - - os: ubuntu-latest - node-version: '*' - install-command: npm install --no-package-lock - machine: '4' fail-fast: false steps: # Sets an output parameter if this is a release PR