Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Run the docker image size inside CircleCI instead of github actions #820

Open
lukasholzer opened this issue Jul 15, 2022 · 0 comments
Open

Run the docker image size inside CircleCI instead of github actions #820

lukasholzer opened this issue Jul 15, 2022 · 0 comments
Labels
echoes/intent: throughput Changes intended at preserving our ability to evolve the software safely and effectively

Comments

@lukasholzer
Copy link
Contributor

Currently the GitHub actions for checking the image size are building the docker image again so we are building the image twice (waste of resources) furthermore does it take way longer than the circleci building.

So just run the manifest check on circleci (maybe build a orb for it and sync with @netlify/infrastructure-pod-release-eng about that.

https://github.com/netlify/whalescale/blob/main/index.js#L23-L36
@lukasholzer lukasholzer added type: feature code contributing to the implementation of a feature and/or user facing functionality echoes/intent: throughput Changes intended at preserving our ability to evolve the software safely and effectively and removed type: feature code contributing to the implementation of a feature and/or user facing functionality labels Jul 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
echoes/intent: throughput Changes intended at preserving our ability to evolve the software safely and effectively
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lukasholzer