New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade the usage of the client to make it more convenient for users. #78

Open

gpBlockchain opened this issue May 30, 2023 · 0 comments

gpBlockchain commented May 30, 2023

Currently, the Rust SDK hardcodes the client as reqwest::blocking::Client::new().

ckb-sdk-rust/src/rpc/mod.rs

Line 45 in 563161a

$struct_name { url, id: 0.into(), client: reqwest::blocking::Client::new(), }

However, sometimes users may need to customize the client, for example:

They may want an asynchronous client.
They may want to set retry options or timeouts.
example :
https://github.com/godwokenrises/godwoken/blob/dbb3c1bf9a4593bae078428d725f7372c2f5401f/crates/rpc-client/src/ckb_client.rs#L12

https://github.com/synapseweb3/forcerelay/blob/07c3463d2200423740366f5f9b0440bdbc17618a/crates/relayer/src/chain/ckb/rpc_client.rs#L72-L81

gpBlockchain changed the title ~~supprot user-defined client~~ Upgrade the usage of the client to make it more convenient for users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment