nephio-controller-manager: missing Gitea secret stalls startup forever

[johnbelamaric]

If the secret is not available (or some other startup issue occurs), then this line:

nephio/operators/nephio-controller-manager/main.go

Line 105 in 31b37fc

g.Start(ctx)

Never returns. Instead, this should be done in a Go routine, and we should throw errors if it's not initialized and someone tries to use it.

ubuntu@nephio-r1-e2e:~$ k -n nephio-system logs -c controller nephio-controller-7cb6bd884d-c2dn6
I0527 15:45:11.452645       1 listener.go:44] controller-runtime/metrics "msg"="Metrics server is starting to listen" "addr"="127.0.0.1:8080"
E0527 15:45:16.454065       1 giteaclient.go:81]  "msg"="cannot get secret" "error"="the cache is not started, can not read objects" 
E0527 15:45:21.454934       1 giteaclient.go:81]  "msg"="cannot get secret" "error"="the cache is not started, can not read objects" 
E0527 15:45:26.457843       1 giteaclient.go:81]  "msg"="cannot get secret" "error"="the cache is not started, can not read objects" 
E0527 15:45:31.459011       1 giteaclient.go:81]  "msg"="cannot get secret" "error"="the cache is not started, can not read objects" 
E0527 15:45:36.461829       1 giteaclient.go:81]  "msg"="cannot get secret" "error"="the cache is not started, can not read objects" 
E0527 15:45:41.462003       1 giteaclient.go:81]  "msg"="cannot get secret" "error"="the cache is not started, can not read objects" 
E0527 15:45:46.466309       1 giteaclient.go:81]  "msg"="cannot get secret" "error"="the cache is not started, can not read objects" 
E0527 15:45:51.467763       1 giteaclient.go:81]  "msg"="cannot get secret" "error"="the cache is not started, can not read objects" 
E0527 15:45:56.469867       1 giteaclient.go:81]  "msg"="cannot get secret" "error"="the cache is not started, can not read objects" 
E0527 15:46:01.471449       1 giteaclient.go:81]  "msg"="cannot get secret" "error"="the cache is not started, can not read objects" 
E0527 15:46:06.473859       1 giteaclient.go:81]  "msg"="cannot get secret" "error"="the cache is not started, can not read objects" 
E0527 15:46:11.474388       1 giteaclient.go:81]  "msg"="cannot get secret" "error"="the cache is not started, can not read objects" 
E0527 15:46:16.478617       1 giteaclient.go:81]  "msg"="cannot get secret" "error"="the cache is not started, can not read objects" 
ubuntu@nephio-r1-e2e:~$ 

/assign @ssharmasandeep

[johnbelamaric]

I am working around this for now by rebuilding, changing the line to go g.Start(ctx) but we should do a proper Go routine with a stop channel, etc., probably. Or perhaps run the Go routine inside the Start method. Not sure.

[ssharmasandeep]

#227

Please review this PR,
however, I am not able to test end-to-end, because my dev environment has missing dependencies for ipam and vlan, I am not sure what is required to be installed and what is the ip:port both reconcilers expect as a proxy client address. Any link to an automation script that does the same will help.

-Sandeep

[johnbelamaric]

nephio-project/test-infra#56 (comment) will set up a complete environment, but I don't have IPAM and VLAN working there yet (nor bootstrap).

In any case, that one has merged so I will close this issue and open another one if there's a problem.