Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to free5GC v3.3.0 #43

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ianchen0119
Copy link

No description provided.

@nephio-prow
Copy link
Contributor

nephio-prow bot commented Jul 16, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign henderiw for approval by writing /assign @henderiw in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot requested review from johnbelamaric and s3wong July 16, 2023 13:52
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 16, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ianchen0119 / name: Ian Chen (3683c1d)

@nephio-prow
Copy link
Contributor

nephio-prow bot commented Jul 16, 2023

Hi @ianchen0119. Thanks for your PR.

I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tliron
Copy link
Contributor

tliron commented Jul 17, 2023

To be clear, this is an upgrade only for NF image generation. The operators would also have to be updated to support the new 3.3.0 configuration format.

@ianchen0119 I'm a bit worried that accepting this PR would mean we won't be able to re-generate the 3.2.1 images anymore (unless we checkout an old commit/tag). I'm not sure how to handle it otherwise. One suggestion is to keep the files in separate subdirectories. For example, under free5gc-images/3.2 we can have all the current files, and then under free5gc-images/3.3 we would have your new changes. The Makefile could do a simple if/else to pick between them. What do you think?

@ianchen0119
Copy link
Author

Hi @tliron

I will push the commit for updating this PR as per your suggestion.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants