Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Use dedicated testing cr instead of default for behat #5349

Draft
wants to merge 1 commit into
base: 9.0
Choose a base branch
from

Conversation

mhsdesign
Copy link
Member

IDK, i did this change yesterday evening because i was deep in this rabbit hole and did not stop :D

The idea was that for the core behavioural test we do technically do not need to run the catchup hooks etc as this is neos part to test. And it slows down the whole test suite see issue: #4878

That would also us to get rid of the doctrine:migrate hack here: #5258 (comment)

But to be true, having the catchup always run on standby did help us in the past. Not because they did assert anything special but to assert they do not throw an exception. And all the testcases in Neos.Neos are not as complex at what the core has to offer for say special Node move strategies :)

For now as quick tip regarding performance:
I always run the tests with catchup hooks disabled: #4904


but maybe we could indeed do this change sometime and continue to run the tests on default nightly or something :)

there is one logic error i made: The Neos.Neos tests still have to work on default because the catchup hooks need to be there.

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant