TASK: Use dedicated testing
cr instead of default
for behat
#5349
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDK, i did this change yesterday evening because i was deep in this rabbit hole and did not stop :D
The idea was that for the core behavioural test we do technically do not need to run the catchup hooks etc as this is neos part to test. And it slows down the whole test suite see issue: #4878
That would also us to get rid of the doctrine:migrate hack here: #5258 (comment)
But to be true, having the catchup always run on standby did help us in the past. Not because they did assert anything special but to assert they do not throw an exception. And all the testcases in Neos.Neos are not as complex at what the core has to offer for say special Node move strategies :)
For now as quick tip regarding performance:
I always run the tests with catchup hooks disabled: #4904
but maybe we could indeed do this change sometime and continue to run the tests on
default
nightly or something :)there is one logic error i made: The Neos.Neos tests still have to work on
default
because the catchup hooks need to be there.Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX
!!!
and have upgrade-instructions