Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Improved CLI output for projection replay #5010

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

bwaidelich
Copy link
Member

@bwaidelich bwaidelich commented Apr 24, 2024

Adds debugging infos to the output of the cr:projectionReplay command and nested progress bars to the output of cr:projectionReplayAll.

Furthermore this adds the until flag to the cr:projectionReplayAll command
Related: #4777

Adds debugging infos to the output of the `cr:projectionReplay` command and nested progress bars to the output of `cr:projectionReplayAll`

Related: #4777
@bwaidelich
Copy link
Member Author

screenrecording_cli_progress.mov

Copy link
Member

@robertlemke robertlemke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bwaidelich bwaidelich merged commit 84d2dfe into 9.0 Apr 25, 2024
11 checks passed
@bwaidelich bwaidelich deleted the feature/improved-cli-output-for-projection-replay branch April 25, 2024 13:29
@mhsdesign
Copy link
Member

The subscription engine makes this kinda hard to implement without exposing too much, so for now well probably revert some parts of it via #5321

Also if this gets ever reimplemented: We should try to not make it the same as before because highestSequenceNumber is not a good indicator for how many events need to be catched up after using the content stream pruner. (it throws basically 80% of the events away, making the progress bar useless.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants