BUGFIX: Force direct access on setting node properties in node data s…

…imilarize
neos · Oct 11, 2024 · d96fbb0 · d96fbb0
1 parent c82b775
commit d96fbb0
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/Neos.ContentRepository/Classes/Domain/Model/NodeData.php b/Neos.ContentRepository/Classes/Domain/Model/NodeData.php
@@ -768,15 +768,14 @@ public function similarize(AbstractNodeData $sourceNode, $isCopy = false)
         ];
         if (!$isCopy) {
             $propertyNames[] = 'creationDateTime';
-            $propertyNames[] = 'lastModificationDateTime';
         }
         if ($sourceNode instanceof NodeData) {
             $propertyNames[] = 'index';
             $propertyNames[] = 'removed';
         }
 
         // We need to force direct access for the following properties, as they don't have a setter in AbstractNodeData
-        $propertyNamesToForceDirectAccess = ['creationDateTime', 'lastModificationDateTime'];
+        $propertyNamesToForceDirectAccess = ['creationDateTime'];
         foreach ($propertyNames as $propertyName) {
             ObjectAccess::setProperty(
                 $this,

diff --git a/Neos.ContentRepository/Tests/Unit/Domain/Model/NodeDataTest.php b/Neos.ContentRepository/Tests/Unit/Domain/Model/NodeDataTest.php
@@ -673,19 +673,16 @@ public function similarizeClearsPropertiesBeforeAddingNewOnes()
     public function similarizeCopiesCreationAndLastModificationDateTimes()
     {
         $creationDateTime = \DateTime::createFromFormat('Y-m-d', '2000-01-01 12:00:00');
-        $lastModificationDateTime = \DateTime::createFromFormat('Y-m-d', '2002-02-02 12:00:00');
 
         /** @var $sourceNode NodeData */
         $sourceNode = $this->getAccessibleMock(NodeData::class, ['addOrUpdate'], ['/foo/bar', $this->mockWorkspace]);
         $this->inject($sourceNode, 'nodeTypeManager', $this->mockNodeTypeManager);
         $sourceNode->_set('nodeDataRepository', $this->createMock(RepositoryInterface::class));
         $sourceNode->_set('creationDateTime', $creationDateTime);
-        $sourceNode->_set('lastModificationDateTime', $lastModificationDateTime);
 
         $this->nodeData->similarize($sourceNode);
 
         self::assertSame($creationDateTime, $this->nodeData->getCreationDateTime());
-        self::assertSame($lastModificationDateTime, $this->nodeData->getLastModificationDateTime());
     }
 
     /**