Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Article link to external website should open a new window #44

Open
vinyll opened this issue Apr 11, 2017 · 4 comments
Open

Article link to external website should open a new window #44

vinyll opened this issue Apr 11, 2017 · 4 comments

Comments

@vinyll
Copy link
Member

vinyll commented Apr 11, 2017

When clicking on a link in an article that refers to an external website, we should automatically add a target=_blank.

@vinyll vinyll added the backend label Apr 11, 2017
@newick
Copy link
Contributor

newick commented Apr 13, 2017

it's against good practices

@vinyll
Copy link
Member Author

vinyll commented Apr 14, 2017

I'm aware of that, and I also see people being confused because they cannot find the site when they clicked.
I'm totally into best practices when they comply with user user experience. I don't observe like this one does (expect for very power users who can preview a link, see it's an external website and make a ctl/cmd+click).

@vinyll
Copy link
Member Author

vinyll commented Apr 14, 2017

Here's a reading I just found when trying to read opinions about target blank: https://medium.com/@dejanulcej/using-target-_blank-for-links-is-not-outdated-anymore-f80299897a0d#d3df

I also just asked (ok, just one non power user) and the reply was "Oh, that!? it's so annoying when I click a link and it quits my website; I can't find it back!"

@newick
Copy link
Contributor

newick commented Apr 15, 2017

oki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants