Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Models do not have all applicable fields #30

Open
dan-kez opened this issue Aug 29, 2016 · 1 comment
Open

Models do not have all applicable fields #30

dan-kez opened this issue Aug 29, 2016 · 1 comment

Comments

@dan-kez
Copy link

dan-kez commented Aug 29, 2016 •
edited
Loading

Models do not currently have all applicable fields:
e.g.
movie.js does not have 'name' or 'tagline'.

This also applies to the other models.
@dan-kez
Copy link
Author

dan-kez commented Aug 30, 2016

So quick update - it looks like these are being pass through with the line _(this).extend(_node.properties), However this allows one to put what ever they want in a node and have no structure.

I may be wrong (still new to this driver and and this code) but it may be better to explicitly call out which fields should exist in the a node.

whatSocks pushed a commit that referenced this issue Sep 9, 2016
@Janekk
Merged in NT-134-express-enable-cors-and-non-get-h (pull request #30)
fe38a44 
NT-134: Express: Enable CORS and non-GET HTTP requests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dan-kez