From 4f26a47eddb76d9e1acc09c200e660fd600e868d Mon Sep 17 00:00:00 2001
From: nonproto <2092019+nonproto@users.noreply.github.com>
Date: Thu, 14 Mar 2024 12:01:39 -0400
Subject: [PATCH] Fix null pointer when backing up and no backup directory is
 selected

---
 .../eu/kanade/tachiyomi/ui/setting/SettingsDataController.kt  | 4 ++++
 constants/src/main/res/values/strings.xml                     | 1 +
 2 files changed, 5 insertions(+)

diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/setting/SettingsDataController.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/setting/SettingsDataController.kt
index e39d424dd8..318ccf51b4 100644
--- a/app/src/main/java/eu/kanade/tachiyomi/ui/setting/SettingsDataController.kt
+++ b/app/src/main/java/eu/kanade/tachiyomi/ui/setting/SettingsDataController.kt
@@ -184,6 +184,10 @@ class SettingsDataController : SettingsController() {
 
     fun createBackup(flags: Int) {
         backupFlags = flags
+        if (storageManager.getBackupDirectory() == null) {
+            activity?.toast(R.string.no_backup_directory_selected)
+            return
+        }
         try {
             // Use Android's built-in file creator
             val intent =
diff --git a/constants/src/main/res/values/strings.xml b/constants/src/main/res/values/strings.xml
index 1859b77e80..af0267482d 100644
--- a/constants/src/main/res/values/strings.xml
+++ b/constants/src/main/res/values/strings.xml
@@ -837,6 +837,7 @@
     <string name="invalid_backup_file">Invalid backup file</string>
     <string name="invalid_backup_file_type">Invalid backup file type: %1$s\nIt should end with ".proto.gz" or ".json".</string>
     <string name="file_is_missing_data">File is missing data.</string>
+    <string name="no_backup_directory_selected">No backup directory selected</string>
     <string name="backup_has_no_manga">Backup does not contain any manga.</string>
     <string name="backup_failed">Backup failed</string>
     <string name="empty_backup_error">No library entries to back up</string>