From 773f8da44b5ad4278dd3f5739adca790c4fb4809 Mon Sep 17 00:00:00 2001 From: Ned Batchelder Date: Thu, 30 May 2024 14:54:16 -0400 Subject: [PATCH] fix(english): don't over-use commas in missing branch descriptions --- coverage/parser.py | 3 +- tests/gold/html/b_branch/b_py.html | 16 ++++---- tests/gold/html/partial/partial_py.html | 12 +++--- tests/gold/html/partial_626/partial_py.html | 14 +++---- tests/test_html.py | 8 ++-- tests/test_parser.py | 44 ++++++++++----------- 6 files changed, 48 insertions(+), 49 deletions(-) diff --git a/coverage/parser.py b/coverage/parser.py index 9c9ffbf0a..efdcc1627 100644 --- a/coverage/parser.py +++ b/coverage/parser.py @@ -375,7 +375,7 @@ def missing_arc_description( msg = f"line {actual_start} {emsg}" if smsg is not None: - msg += f", because {smsg.format(lineno=actual_start)}" + msg += f" because {smsg.format(lineno=actual_start)}" msgs.append(msg) @@ -656,7 +656,6 @@ def __init__(self, body: Sequence[ast.AST]) -> None: self.lineno = body[0].lineno # TODO: some add_arcs methods here don't add arcs, they return them. Rename them. -# TODO: the cause messages have too many commas. # TODO: Shouldn't the cause messages join with "and" instead of "or"? def _make_expression_code_method(noun: str) -> Callable[[AstArcAnalyzer, ast.AST], None]: diff --git a/tests/gold/html/b_branch/b_py.html b/tests/gold/html/b_branch/b_py.html index 5bbd60cda..d4d4246e5 100644 --- a/tests/gold/html/b_branch/b_py.html +++ b/tests/gold/html/b_branch/b_py.html @@ -5,7 +5,7 @@ Coverage for b.py: 70% - +
@@ -66,8 +66,8 @@

^ index     » next       - coverage.py v7.5.1a0.dev1, - created at 2024-04-25 08:04 -0400 + coverage.py v7.5.4a0.dev1, + created at 2024-05-30 14:47 -0400