This repository has been archived by the owner on Oct 4, 2024. It is now read-only.
fix: bring back ledger support #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings back Ledger support, that was removed while transitioning to v4.0.0. It uses the latest package version of Ledger Transport (used to talk with Ledger) and brings some improvements on error handling.
The most important change with respect to v3.5.0 is that the Ledger is now treated as a
utilinstead of amiddleware. This way, we can handle Ledger errors on the command, meaning that an error will print the Ledger error message, and NOT the (error message + stack trace + command help).Finally, the commands where changed, now
useLedgerKeyis a boolean, and the path is set apart. This introduces no friction to the users using the default path (which we assume is the majority), making the commands fully retrocompatible with v3.5.0 for them.Users that do select paths will need to use the
--ledgerPathflag