Skip to content
This repository has been archived by the owner on Jul 16, 2022. It is now read-only.

Bootstrap update for v4 #225

Open
gbjbaanb opened this issue Apr 26, 2020 · 2 comments · May be fixed by #226
Open

Bootstrap update for v4 #225

gbjbaanb opened this issue Apr 26, 2020 · 2 comments · May be fixed by #226
Labels
enhancement help wanted

Comments

@gbjbaanb
Copy link

The bootstrap initialisation code (which is a really neat idea BTW) looks for a

temporary element for styling of the main frame,

The panel class was removed in bootstrap 3. In Boostrap 4, we have the "card" class that does the same things.

So the bootstrap.js init code just needs panel replacing with card.

Another niggle with the bootstrap code is that the z-index should be set to make the picker appear above a modal. Bootstrap currently sets the z-index of its modals to be 1050.
@nazar-pc
Copy link
Owner

I was not using bootstrap integration for ages, so if you're willing to make a PR to make it work with Bootstrap v4 that would be great!

@gbjbaanb gbjbaanb linked a pull request Apr 26, 2020 that will close this issue
Open
@gbjbaanb
Copy link
Author

@nazar-pc consider it done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

updated panel to BS4
2 participants
@nazar-pc @gbjbaanb