Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init Order is not applied when order_by contains a value that is not orderable #349

Open
pehbehbeh opened this issue Jun 17, 2024 · 2 comments
Open

Init Order is not applied when order_by contains a value that is not orderable #349

pehbehbeh opened this issue Jun 17, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@pehbehbeh
Copy link
Member

pehbehbeh commented Jun 17, 2024 •
edited by Flo0807
Loading

The apply_criteria function expects a field_name to be present in the order criteria, but we do not set the value in the case order_by contains a value that is not orderable.

See https://github.com/naymspace/backpex/blob/0.3.1/lib/backpex/live_resource.ex#L1336
@pehbehbeh pehbehbeh added the bug Something isn't working label Jun 17, 2024
@pehbehbeh
Copy link
Member Author

@Flo0807 This is from our internal issue tracker. Could you please add permalinks to the relevant code parts? The links are out of date.

@pehbehbeh pehbehbeh moved this to Specification in Backpex Development Jun 17, 2024
@Flo0807
Copy link
Collaborator

Flo0807 commented Jun 17, 2024

@Flo0807 This is from our internal issue tracker. Could you please add permalinks to the relevant code parts? The links are out of date.

I updated the links in the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Backpex Development
Status: Specification
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pehbehbeh @Flo0807