-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instructions Clarification #2
Comments
@jessemorton Yes, I just did the same thing...took me a while to work out that I needed to convert over API token and not oath. @nawarkhede Are you open to pull requests on this, if I extend what you have here to support either an API token or OAuth? |
@ktbyers yes I am open to pull requests on this. It will be great if we support both API token as well as OAuth. Let me know your thoughts on this. |
@nawarkhede Okay, I will probably try to submit a PR on this. Let me double check my code and make sure I didn't break anything from your original oauth solution. |
FYI, I never upstreamed this, but I did implement token support in my fork: https://github.com/ktbyers/getdrip/blob/master/getdrip/__init__.py#L31 |
Actually I just tried the HEAD on this repo and it seems it works with the normal API tokens. It's just too bad it never was pushed to PyPi. |
It might help others to clarify that for the token being passed to GetDripAPI, it's necessary to go through the OAuth steps on the Drip site. At first I was trying to use my non-OAuth personal API token, which results in not-allowed responses from Drip.
Thanks for the tool!
The text was updated successfully, but these errors were encountered: