Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions Clarification #2

Open
jessemorton opened this issue Jul 27, 2016 · 5 comments
Open

Instructions Clarification #2

jessemorton opened this issue Jul 27, 2016 · 5 comments

Comments

@jessemorton
Copy link

jessemorton commented Jul 27, 2016

It might help others to clarify that for the token being passed to GetDripAPI, it's necessary to go through the OAuth steps on the Drip site. At first I was trying to use my non-OAuth personal API token, which results in not-allowed responses from Drip.

Thanks for the tool!

@ktbyers
Copy link

ktbyers commented Aug 14, 2016

@jessemorton Yes, I just did the same thing...took me a while to work out that I needed to convert over API token and not oath.

@nawarkhede Are you open to pull requests on this, if I extend what you have here to support either an API token or OAuth?

@nawarkhede
Copy link
Owner

nawarkhede commented Aug 19, 2016

@ktbyers yes I am open to pull requests on this. It will be great if we support both API token as well as OAuth. Let me know your thoughts on this.

@ktbyers
Copy link

ktbyers commented Aug 23, 2016

@nawarkhede Okay, I will probably try to submit a PR on this. Let me double check my code and make sure I didn't break anything from your original oauth solution.

nawarkhede pushed a commit that referenced this issue Oct 25, 2017
@ktbyers
Copy link

ktbyers commented Jul 17, 2019

FYI, I never upstreamed this, but I did implement token support in my fork:

https://github.com/ktbyers/getdrip/blob/master/getdrip/__init__.py#L31

@bwesen
Copy link

bwesen commented Jul 17, 2019

FYI, I never upstreamed this, but I did implement token support in my fork:

https://github.com/ktbyers/getdrip/blob/master/getdrip/__init__.py#L31

Actually I just tried the HEAD on this repo and it seems it works with the normal API tokens. It's just too bad it never was pushed to PyPi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants