Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update passport-oauth to ^1.0.0 #8

Open
analog-nico opened this issue Nov 9, 2015 · 4 comments
Open

Update passport-oauth to ^1.0.0 #8

analog-nico opened this issue Nov 9, 2015 · 4 comments

Comments

@analog-nico
Copy link

Unless this library upgrades to passport-oauth ^1.0.0 it will crash req.logIn(...) when the app is using the latest version of Passport. This is caused by introducing lazy session initialization in passport 0.3.0. See the technical details and Jared's explanation.

Let me know if I can help.

@analog-nico analog-nico changed the title Critical: Update passport-oauth to ^1.0.0 Update passport-oauth to ^1.0.0 Nov 9, 2015
@analog-nico
Copy link
Author

FYI, [email protected] just got released which applies a general patch. So I removed the "Critical" in the title.

@mooyoul
Copy link
Contributor

mooyoul commented Jan 31, 2016

@analog-nico I've created related PR #5 about 6 months ago, but they don't accept my PR until now.
(yes, I tried to contact owner/maintainers, but they didn't respond.)

I think this repository is NOT maintained anymore. Sad.

FYI for someone who looking for similar issues.
Consider using my forked project. It is Active, Maintained, and work nicely on production products.

@analog-nico
Copy link
Author

@mooyoul Kudos for continuing the maintenance in your fork!

@mooyoul
Copy link
Contributor

mooyoul commented Feb 1, 2016

Oh-oh-oh. they just merged my PR. Yay!

@analog-nico FYI, Your issue has been resolved ;) Please update status of this issue. Thanks for your support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants