Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build from master on Ubuntu 18.04 #940

Closed
skironDotNet opened this issue Mar 8, 2022 · 19 comments
Closed

Unable to build from master on Ubuntu 18.04 #940

skironDotNet opened this issue Mar 8, 2022 · 19 comments

Comments

@skironDotNet
Copy link

used your script to build navcoin on Ubuntu 18.04
All runs ok... well had to add 1 lib by hand navcoin/navcoin-dev-tools#6

#install unbound ok
autogen, configure all ok, but fails on make

  cd navcoin-core
  git checkout master
  cd depends
  make
  cd ..
  ./autogen.sh
  ./configure --enable-debug --enable-tests --prefix=`pwd`/depends/`uname -m`-pc-linux-gnu 
  make -j$(nproc)

image

Any idea? Should I build from release tag? or something is broken? Can your test your script with fresh Ubuntu VM? https://github.com/navcoin/navcoin-dev-tools/blob/master/ubuntu-18.04-navcoin-core-dev-setup.sh

@skironDotNet
Copy link
Author

Same error when build from Tag 7.0.1 which is your release code. How to build?

@aguycalled
Copy link
Member

@mxaddict
Copy link
Contributor

mxaddict commented Mar 8, 2022 via email

@skironDotNet
Copy link
Author

@mxaddict I have all those libs installed, it's not about that.

I'll ping you back once I test the guide from @aguycalled

@skironDotNet
Copy link
Author

@aguycalled your guide helped. The key part for Ubuntu 18 is
image

This note could be presented as warning, because without it can't really build.
Also would be good idea to update in git documentation with that. And maybe the script https://github.com/navcoin/navcoin-dev-tools/blob/master/ubuntu-18.04-navcoin-core-dev-setup.sh

Should update CMAKE automatically on 18?

@aguycalled
Copy link
Member

would you like to take this task and update https://github.com/navcoin/navcoin-dev-tools? @mxaddict

@skironDotNet
Copy link
Author

skironDotNet commented Mar 9, 2022

Seems like I spoke too early... So it was building and building but ended same way as start with older CMAKE

image

Are you sure there are no errors in Makefile? but then it makes no sense because you wouldn't be able to make either.
I could try Ubuntu 20... but before I do I'll make one more build form 0, because here already used depends from older CMAKE

@aguycalled
Copy link
Member

I see no error in the screenshot. you should have the binaries in src/navcoin-cli and src/qt/navcoin-qt

@mxaddict
Copy link
Contributor

mxaddict commented Mar 9, 2022

This looks like the build worked fine.

try running the gui wallet with ./src/qt/navcoin-qt -devnet

@mxaddict
Copy link
Contributor

mxaddict commented Mar 9, 2022

@aguycalled @skironDotNet could you test this PR and see if it's working as I expected: navcoin/navcoin-dev-tools#7

@mxaddict
Copy link
Contributor

mxaddict commented Mar 9, 2022

This PR changes the build script to work with both 18.04 and 20.04

@skironDotNet
Copy link
Author

skironDotNet commented Mar 10, 2022

Ok, sorry, I thought this is an error #940 (comment) didn't check the src/qt folder. The QT client got build.

Thank you for your support, and sorry for unnecessary confusion.

@skironDotNet
Copy link
Author

@mxaddict regarding navcoin/navcoin-dev-tools#7 I don't enable debug and disable tests to make build faster for me. Tests are good for you to test after new changes I'm assuming

My core part of build script is this (after having all needed libs installed and pulled git repo)

cd depends
sudo make -j$(nproc)
cd ..
sudo ./autogen.sh
sudo ./configure --disable-tests --prefix=`pwd`/depends/`uname -m`-pc-linux-gnu 
sudo make -j$(nproc)

So needed updated CMAKE version on 18.04 as I mentioned here #940 (comment)
and needed exec all core commands as sudo

Also to minimize binary size at the end I call

strip navcoind
strip navcoin-qt

and so on

@mxaddict
Copy link
Contributor

You should not need sudo unless the files in the repo are not owned by the current user running the commands

@mxaddict
Copy link
Contributor

mxaddict commented Mar 10, 2022

I've updated the script in dev-tools repo to use newer cmake. navcoin/navcoin-dev-tools#7

If you have a fresh ubuntu 18.04 vm, maybe give it a try.

@stenolog
Copy link

stenolog commented May 4, 2024

@aguycalled, looks closable

@skironDotNet
Copy link
Author

Nobody uses 18.04 anymore, just close it

@stenolog
Copy link

stenolog commented May 6, 2024

@skironDotNet , you (as the author) should be able to close the issue

@skironDotNet
Copy link
Author

somehow there were no option to close from github mobile app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@mxaddict @skironDotNet @aguycalled @stenolog and others