-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize App size: Convert PNG Images into SVG or Vector Icons #164
Comments
I completed for removing icons first, |
My suggestion to this issue was to utilize personalized svg's. Why? First because we can have svg personalized to the app, which is impossible to have using libraries as vector icons. To make this implementation is necessary: Step I
Step II
Step IIIInsert inside
I tried to make this config inside Whisper wallet code, but as we already have one config to use @ui-kitten I had some troubles. Step IV
With all the previous steps performed we can use svg as a module, with that, inside our code we can create a folder to svg's, import svg files and use it in our code as a component: import ArrowLeftSVG from '../../images/arrow-left.svg';
const App = () => {
...
return (<ArrowLeftSVG /> )
} |
There is already some work about this issue on pr #167. But I think eventually removing the kitten dependency would be good. What do you think? |
If we can remove the Kitten dependency I won't more problems to use that solution. I saw the #167 pull request, but I really think that we can use better ways to do this migration from png to svg. What I need to have permission to submit pull request? |
perfect! we can take your path then. you can just fork the repository and open a pull request. thanks! |
The text was updated successfully, but these errors were encountered: