Update to DiffSync 2.0 #349
Conversation
Also needed to disable ChatOps while we wait for it to be updated for ipfabric library. Also updated our ipfabric dependencies. This will be break all third party Apps as the create() signature has changed and will also require updates to class attributes.
… have None default for Optional. Also fixed a few default types that were using list() and should be [].
jdrew82
added
type: major feature
integration: servicenow
jdrew82
requested review from
glennmatthews,
qduk,
a team,
alhogan and
chadell
as code owners
…hema and attrs during tests.
There was a problem hiding this comment.
Can you make a todo note for this to link to the "Upgrading" docs from diffsync from the SSoT docs? Apart from that, LGTM. Thanks for doing all this work!
EDIT: Here it is: https://diffsync.readthedocs.io/en/latest/upgrading/index.html#upgrading
| jsonschema = "^4.18.0" | ||
| attrs = "^22.2.0" |
There was a problem hiding this comment.
Can you put a comment that explains why we need these two explicit dependencies?
There was a problem hiding this comment.
This was done temporarily due to the versions being chosen by poetry before were throwing a lot of errors during testing.
| myst-parser = "^0.15.2" | ||
| nautobot-chatops = { version = "^3.0.0", extras = ["ipfabric"] } | ||
| myst-parser = "^2.0.0" | ||
| # nautobot-chatops = { version = "^3.0.0", extras = ["ipfabric"] } |
There was a problem hiding this comment.
Why are we commenting this out?
There was a problem hiding this comment.
This was done temporarily until ChatOps gets updated also. It's also using ipfabric-diagrams library which is deprecated and doesn't support pydantic 2.0. We need to replace that with ipfabric library and update any uses of the diagrams library to use how it's done in the standard ipfabric library now.
There was a problem hiding this comment.
I would like it if we remove this dependency as it makes it very difficult from my side to develop as I have to update Chatops, wait for a release, and then can update SSOT.
This PR is to make all the required changes to support DiffSync 2.0 and pydantic 2.0.