Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add '--display-subscriptions-column' flag #69

Closed
dsidirop opened this issue May 13, 2022 · 2 comments
Closed

Add '--display-subscriptions-column' flag #69

dsidirop opened this issue May 13, 2022 · 2 comments

Comments

@dsidirop
Copy link
Contributor

dsidirop commented May 13, 2022 •
edited
Loading

When grabbing csv-snapshots via nats-top it's sometimes useful to display the subscriptions column but in order to do that we need a new '--display-subscriptions-column' flag.

PS: I'll take up on this errand and submit a pull request.
@dsidirop dsidirop changed the title Add --display-subscriptions-columns flag Add --display-subscriptions-column flag May 13, 2022
@dsidirop dsidirop changed the title Add --display-subscriptions-column flag Add '--display-subscriptions-column' flag May 13, 2022
@dsidirop
Copy link
Contributor Author

Added a pull request

#70

Also contains #62 which is a trivial feature-implementation

wallyqs pushed a commit that referenced this issue May 25, 2022
@dsidirop @ksidirop-laerdal
#69 new flag --display-subscriptions-column (#70)
94feb2b 
* chore (.gitignore): ignore .vscode folder and any *.code-workspace files

* feat (--version): add support for printing version via the --version flag

* feat (--display-subscriptions-column): new flag

* feat (version): bump to 0.5.3 (old was: 0.5.2)

* fix (csv output): when emitting csv output via '-o' the subs will be printed separated by whitespace chars instead of ',' because the ',' is frequently reserved to separate entire csv-columns in the resulting output

* fix (nats-top.go): fix a bug which was causing the SUBSCRIPTIONS column to not be delimiter-separator when the --display-subscriptions-column flag would be used in conjunction with -o

Co-authored-by: Kyriakos Sidiropoulos <[email protected]>
@dsidirop
Copy link
Contributor Author

Got merged so closing this.

dsidirop added a commit to dsidirop/nats-top that referenced this issue May 26, 2022
@dsidirop
Merge branch 'main' of https://github.com/nats-io/nats-top into ksidi…
da7cd50 
…rop/NTOP-0069-new-flag--display-subscriptions-column

* 'main' of https://github.com/nats-io/nats-top:
  nats-io#69 new flag  --display-subscriptions-column (nats-io#70)
wallyqs pushed a commit that referenced this issue May 26, 2022
@dsidirop @ksidirop-laerdal
#69 new flag display subscriptions column - addendum for README.md (#71)
2fce567 
* feat (display-subscriptions-column): add the '-u' shorthand for the long option '--display-subscriptions-column' and updated the README.md file accordingly to mention these new options

Co-authored-by: Kyriakos Sidiropoulos <[email protected]>
dsidirop added a commit to dsidirop/nats-top that referenced this issue Jun 4, 2022
@dsidirop
Merge branch 'main' of https://github.com/nats-io/nats-top
36e21f1 
* 'main' of https://github.com/nats-io/nats-top:
  nats-io#69 new flag  display subscriptions column - addendum for README.md (nats-io#71)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dsidirop