Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nats-top --version keeps showing "nats-top v0.0.0" #102

Open
jm20122012 opened this issue Oct 10, 2024 · 1 comment
Open

nats-top --version keeps showing "nats-top v0.0.0" #102

jm20122012 opened this issue Oct 10, 2024 · 1 comment
Labels
defect Suspected defect such as a bug or regression

Comments

@jm20122012
Copy link

What version were you using?

$ docker image ls --format "table {{.Repository}}\t {{.Tag}}"
REPOSITORY                                       TAG
nats                                             2.10.18-alpine3.20

What environment was the server running in?

$ lsb_release -a
Distributor ID:	Ubuntu
Description:	Ubuntu 20.04.6 LTS
Release:	20.04
Codename:	focal

Is this defect reproducible?

Yes. Running the nats-top --version command consistently outputs nats-top v0.0.0

$ nats-top --version
nats-top v0.0.0

Given the capability you are leveraging, describe your expectation?

I would expect the output to contain the appropriate nats-top version, which the version I downloaded was v0.6.2 as shown in the following output from the install:

$ go install github.com/nats-io/[email protected]
go: downloading github.com/nats-io/nats-top v0.6.2
go: downloading gopkg.in/gizak/termui.v1 v1.0.0-20151021151108-e62b5929642a
go: downloading golang.org/x/crypto v0.26.0
go: downloading golang.org/x/time v0.6.0
go: downloading golang.org/x/sys v0.24.0
go: downloading github.com/mattn/go-runewidth v0.0.16
go: downloading github.com/nsf/termbox-go v1.1.1

$ nats-top --version
nats-top v0.0.0

$ nats-top --help
usage: nats-top [-s server] [-m http_port] [-ms https_port] [-n num_connections] [-d delay_secs] [-r max] [-o FILE] [-l DELIMITER] [-sort by]
                [-cert FILE] [-key FILE] [-cacert FILE] [-k] [-b] [-v|--version] [-u|--display-subscriptions-column]

Given the expectation, what is the defect you are observing?

The defect is that the nats-top --version command is not showing the correct version, and instead just shows v0.0.0.

@jm20122012 jm20122012 added the defect Suspected defect such as a bug or regression label Oct 10, 2024
@jm20122012
Copy link
Author

jm20122012 commented Oct 11, 2024

It actually looks like "0.0.0" was hard-coded here. Was this intentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Suspected defect such as a bug or regression
Projects
None yet
Development

No branches or pull requests

1 participant