Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BPM (off by 2x) #19

Open
nathanleiby opened this issue Nov 7, 2024 · 0 comments
Open

Fix BPM (off by 2x) #19

nathanleiby opened this issue Nov 7, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@nathanleiby
Copy link
Owner

nathanleiby commented Nov 7, 2024

ideally the data model for user_hits and desired_hits aligns nicely, i.e. 1.0 is beat 1, 2.0 is beat 2. So e.g. 16th notes are 0.25 in length

I believe today it's off by 2, i.e. bpm=120 in app is actually bpm=60.

This isn't strictly a bug as everything "works" and you can abstract over it in the UI. But it would make the internals and data model clearer if we fixed it!

@nathanleiby nathanleiby changed the title Fix Kira clock to actually be BPM Fix BPM (off by 2x) Nov 7, 2024
@nathanleiby nathanleiby added the enhancement New feature or request label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant