You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Multiple return codes are defined as -1, this defeats the purpose of named codes and doesn't allow for unique handling, checking the error code is also not actually testing that the expected incorrect code was returned.
Is your feature request related to a problem? Please describe.
Multiple return codes are defined as
-1
, this defeats the purpose of named codes and doesn't allow for unique handling, checking the error code is also not actually testing that the expected incorrect code was returned.cFE/modules/tbl/fsw/src/cfe_tbl_internal.h
Line 50 in 84ba9a9
cFE/modules/tbl/fsw/src/cfe_tbl_task.h
Lines 59 to 78 in 84ba9a9
Note there's at least one cases where an index is initialized to one of these error codes, which is especially fragile (#1519)
Describe the solution you'd like
Defined unique error codes, if they every get passed out an API really they should be defined in cfe_error.h
Describe alternatives you've considered
None
Additional context
Code review
Requester Info
Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered: