Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: review AssertionError internally #1894

Open
MarcoGorelli opened this issue Jan 29, 2025 · 0 comments
Open

chore: review AssertionError internally #1894

MarcoGorelli opened this issue Jan 29, 2025 · 0 comments

Comments

@MarcoGorelli
Copy link
Member

I think we should only be raising AssertionError for cases when safety assertions fail, in code that we don't expect users to encounter

It would be good to review how we're using AssertionError and raise better error types where appropriate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MarcoGorelli