Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: run test suite with new_streaming=True for Polars lazy #1875

Open
MarcoGorelli opened this issue Jan 27, 2025 · 0 comments · May be fixed by #1898
Open

test: run test suite with new_streaming=True for Polars lazy #1875

MarcoGorelli opened this issue Jan 27, 2025 · 0 comments · May be fixed by #1898
Labels
high priority Your PR will be reviewed very quickly if you address this tests

Comments

@MarcoGorelli
Copy link
Member

Similarly to

narwhals/tests/utils.py

Lines 86 to 89 in 04274b3

if result.implementation is Implementation.POLARS and os.environ.get(
"NARWHALS_POLARS_GPU", False
): # pragma: no cover
result = result.to_native().collect(engine="gpu")

we should also have an environment variable to run the tests with Polars' new streaming engine. This can help with finding issues such as pola-rs/polars#20930

@MarcoGorelli MarcoGorelli added high priority Your PR will be reviewed very quickly if you address this tests labels Jan 27, 2025
@luke396 luke396 linked a pull request Jan 30, 2025 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Your PR will be reviewed very quickly if you address this tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant