Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close() on RTMP server #26

Open
ericxtang opened this issue Apr 6, 2017 · 0 comments · May be fixed by #106
Open

Close() on RTMP server #26

ericxtang opened this issue Apr 6, 2017 · 0 comments · May be fixed by #106

Comments

@ericxtang
Copy link
Collaborator

Right now there is no way to close the RTMP server manually. The Golang http package is an example to follow here - https://golang.org/pkg/net/http/#Server.Close

@nareix I'm happy to make a PR - keep a reference to the listener in rtmp.Server{}, and add a Close() function to call listener.Close(). Does that sound reasonable?
@dmorn dmorn linked a pull request Mar 17, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add listener close function kim-company/joy4
1 participant
@ericxtang