Expose NNG_MAX_EXPIRE_THREADS via CMake #1619
Comments
|
so what does this patch help? |
Related to "nng creates a massive amount of threads on high core count machines" |
|
Yes, it would be good to have this as a tunable in the CMakeLists. |
gdamore
changed the title
|
@gdamore at the end only the NNG_MAX_EXPIRE_THREADS was added. Code still uses NNG_EXPIRE_THREADS that effectively overrides NNG_MAX_EXPIRE_THREADS. Should we apply something similar to how taskq limits are set? Having a max value ( And having a I have an MR for that if you want. |
|
Go ahead and submit the PR. Cannot promise it will merge, but it might, and cannot hurt to look. The taskqs needs to have a minimum of 2, or else deadlocks may occur. |
This change makes expire threads tunable follows the same strategy as taskq threads tunables. Add NNG_NUM_EXPIRE_THREADS to override the default behaviour (`n_cpu` expire threads). The NNG_MAX_EXPIRE_THREADS limit is always applied if > 0, even if you specifiy the desired number of threads using NNG_NUM_EXPIRE_THREADS. NNG_EXPIRE_THREADS is not used anymore. This was only referenced in code but never defined on CMake. The logic to cap expire threads between 1 and 256 was removed. If user set no limits, whatever value they choose will be used instead of being silently overriden by us.
This change makes expire threads tunable follows the same strategy as taskq threads tunables. Add NNG_NUM_EXPIRE_THREADS to override the default behavior (`n_cpu` expire threads). The NNG_MAX_EXPIRE_THREADS limit is always applied if > 0, even if you specify the desired number of threads using NNG_NUM_EXPIRE_THREADS. NNG_EXPIRE_THREADS is not used anymore. This was only referenced in the code but never defined on CMake. The logic to cap expire threads between 1 and 256 was removed. If users set no limits, whatever value they choose will be used instead of being silently overridden by us.
This change makes expire threads tunable follows the same strategy as taskq threads tunables. Add NNG_NUM_EXPIRE_THREADS to override the default behavior (`n_cpu` expire threads). The NNG_MAX_EXPIRE_THREADS limit is always applied if > 0, even if you specify the desired number of threads using NNG_NUM_EXPIRE_THREADS. NNG_EXPIRE_THREADS is not used anymore. This was only referenced in the code but never defined on CMake. The logic to cap expire threads between 1 and 256 was removed. If users set no limits, whatever value they choose will be used instead of being silently overridden by us.
The define NNG_EXPIRE_THREADS not set in CMakeLists.txt. Define is used in nni_aio_sys_init().
Fix in CMakeLists.txt:
if (NNG_EXPIRE_THREADS)
add_definitions(-DNNG_EXPIRE_THREADS=${NNG_EXPIRE_THREADS})
endif ()
mark_as_advanced(NNG_EXPIRE_THREADS)
The text was updated successfully, but these errors were encountered: