pipe: hold on to the socket / dialer until the pipe is freed

This avoids a problem where the teardown of the socket proceeds and orphans the pipe, which can manifest as a leak at shutdown.
nanomsg · Dec 9, 2024 · d7df456 · d7df456
1 parent f292cc6
commit d7df456
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/core/pipe.c b/src/core/pipe.c
@@ -40,6 +40,8 @@ pipe_destroy(void *arg)
 	p->p_proto_ops.pipe_fini(p->p_proto_data);
 	p->p_tran_ops.p_fini(p->p_tran_data);
 
+	nni_pipe_remove(p);
+
 	nni_free(p, p->p_size);
 }
 
@@ -70,8 +72,6 @@ pipe_reap(void *arg)
 	p->p_proto_ops.pipe_stop(p->p_proto_data);
 	p->p_tran_ops.p_stop(p->p_tran_data);
 
-	nni_pipe_remove(p);
-
 	nni_pipe_rele(p);
 }