Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private message listener should call createUser #117

Open
briangreenery opened this issue Mar 17, 2014 · 3 comments
Open

Private message listener should call createUser #117

briangreenery opened this issue Mar 17, 2014 · 3 comments

Comments

@briangreenery
Copy link

It looks like the pm listener should probably be calling createUser so that the user id is set.

@Boggart
Copy link

Boggart commented Apr 10, 2014

Without this any scripts that use the user id fail when used over pm.

@jgable
Copy link
Collaborator

jgable commented Apr 11, 2014

Seems like a pretty straight forward change. If either of you have time to put something together I'd be able to merge and publish it pretty quickly.

@Boggart
Copy link

Boggart commented Apr 11, 2014

I've got it changed on my fork but when I update my hubot on heroku it seems to just use the old version even though I changed package.json to point to github, so I can't test right now. If I manage to get hubot/heroku to pull my repo and it works I'll submit a pull request.

https://github.com/Boggart/hubot-irc

EDIT: I still haven't got heroku to use my fork, it's set to and just doesn't. If anyone else can test my fork to see if it fixes, I'd greatly appreciate it, if not I do plan to move my hubot to either openshift or my own server. When I do, I'll see if I can't get it to use my version.

Edit 2: I'm unable to do anything with this at this time, I'm doing this edit because it seems crappy to have disappeared after talking about fixing it. (Channel died, some auto-update broke the bot and I don't have the time.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants