Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MapBuilder crash when load MH2O #32

Closed
oiramario opened this issue Aug 14, 2022 · 2 comments
Closed

MapBuilder crash when load MH2O #32

oiramario opened this issue Aug 14, 2022 · 2 comments
Labels

Comments

@oiramario
Copy link

MapBuilder crash when build data of Azeroth for WtoLK.
https://github.com/namreeb/namigator/blob/master/parser/Adt/Chunks/MH2O.cpp#L42
instance.Width and instance.Height are both zero.
It works fine for TBC because header.Mh2oOffset is always zero.

during researching I found the 0x14 offset cause this issue.
https://github.com/namreeb/namigator/blob/master/parser/Adt/Adt.cpp#L98
building success after remove this 0x14 offset.

what's your suggestion?

@namreeb
Copy link
Owner

namreeb commented Sep 7, 2022

Your fix is probably right. But I'm leaving this open to remind me to include some testing data in the wrath format.

@namreeb
Copy link
Owner

namreeb commented Sep 9, 2022

I changed my mind. I fixed this issue and left myself a note with #33. Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants