Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: More Dockerfile to distribution build support #1582

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

paranlee
Copy link
Contributor

Add suse and Latest Distribution Dockerfile. docker build and run uftrace (#1552 )

@paranlee paranlee changed the title misc: More Docker File to distribution build support misc: More Dockerfile to distribution build support Sep 12, 2022
@honggyukim
Copy link
Collaborator

honggyukim commented Sep 12, 2022

Thanks for the work, but I feel like "Add dockerfiles for xxx" patches can be squashed into a single patch. You can add Signed-off-by lines together for other authors.

In addition, could you write the commit message more in details? I've made the same request at #1513 (comment) so please read it and update the commit message again.

the current commit message doesn't explain what the patches do. You can think that the commit message is a letter to code reviewers and future readers. (or even to yourself)

Rather than explaining many things in the comment here, you better explain what the patches do in the commit message as much as possible so that reviewers do not have to ask. Please read other commit messages and get reference from them.

@honggyukim
Copy link
Collaborator

It'd be much more useful if you write the steps to run uftrace under those docker images in the commit message.

Update Docker file for lastest distributions
such as latest fedora, ubuntu, CentOS, Rocky Linux
and opensuse 15

Reported-by: Paran Lee <[email protected]>
Signed-off-by: JeongWan Gho <[email protected]>
Signed-off-by: Yusun Choi <[email protected]>
Signed-off-by: Paran Lee <[email protected]>
@namhyung
Copy link
Owner

It'd be much more useful if you write the steps to run uftrace under those docker images in the commit message.

Agreed. Please add something like misc/docker/run.sh or something to do the build test for all (or some selected) docker images. Optionally it can give a shell prompt.

@yskelg
Copy link
Contributor

yskelg commented Oct 23, 2024

Thank you @namhyung for the review. I will write a script that can build and run all or each of the Docker images. Additionally, I will add Docker files to match the latest distribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants