From ad2671495be9d7150cd3ed306a6fb68bcfc57758 Mon Sep 17 00:00:00 2001 From: jefft0 <> Date: Mon, 25 Nov 2019 12:36:07 -0800 Subject: [PATCH] Interest: Change the MustBeFresh default value to false. Refs #5055. --- CHANGELOG | 9 ++++++++- src/net/named_data/jndn/Interest.java | 6 +++--- src/net/named_data/jndn/Node.java | 1 + 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/CHANGELOG b/CHANGELOG index 93bb02e7..a2f947de 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,6 +1,13 @@ -jNDN v0.23 (2019-10-04) +Interim changes since jNDN v0.23 (2019-11-25) --------------------------------------------- +Changes +* https://redmine.named-data.net/issues/5055 In Interest, changed the + MustBeFresh default value to false. + +jNDN v0.23 (2019-10-04) +----------------------- + Changes * https://redmine.named-data.net/issues/4813 In Face, added putNack(). * https://github.com/named-data/jndn/pull/24 Aimd pipelining in Segment fetcher (Thanks, Ritik!) diff --git a/src/net/named_data/jndn/Interest.java b/src/net/named_data/jndn/Interest.java index 71048e92..0680b59a 100644 --- a/src/net/named_data/jndn/Interest.java +++ b/src/net/named_data/jndn/Interest.java @@ -325,7 +325,7 @@ public class Interest implements ChangeCountable { getChildSelector() { return childSelector_; } /** - * Get the must be fresh flag. If not specified, the default is true. + * Get the must be fresh flag. If not specified, the default is false. * @return The must be fresh flag. */ public final boolean @@ -555,7 +555,7 @@ else if (!linkWireEncoding_.isNull()) { /** * Set the MustBeFresh flag. * @param mustBeFresh True if the content must be fresh, otherwise false. If - * you do not set this flag, the default value is true. + * you do not set this flag, the default value is false. * @return This Interest so that you can chain calls to update values. */ public final Interest @@ -996,7 +996,7 @@ else if (!linkWireEncoding_.isNull()) { private final ChangeCounter keyLocator_ = new ChangeCounter(new KeyLocator()); private final ChangeCounter exclude_ = new ChangeCounter(new Exclude()); private int childSelector_ = -1; - private boolean mustBeFresh_ = true; + private boolean mustBeFresh_ = false; private double interestLifetimeMilliseconds_ = -1; private Blob nonce_ = new Blob(); private long getNonceChangeCount_ = 0; diff --git a/src/net/named_data/jndn/Node.java b/src/net/named_data/jndn/Node.java index 71b5c850..1537db64 100644 --- a/src/net/named_data/jndn/Node.java +++ b/src/net/named_data/jndn/Node.java @@ -851,6 +851,7 @@ public static class Info { Interest commandInterest = new Interest(); commandInterest.setCanBePrefix(true); + commandInterest.setMustBeFresh(true); // Determine whether to use remote prefix registration. boolean faceIsLocal;