Rework face API and fix transports #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Done with this, not doing ethernet at the moment |
zjkmxy
approved these changes
Dec 15, 2024
| time.Sleep(10 * time.Second) | ||
|
|
||
| // Iterate the face table | ||
| t.faces.Range(func(_, face interface{}) bool { |
There was a problem hiding this comment.
(Not related) Really want to see generics supported in sync package, but it seems to still have a long way to go: golang/go#47657
There was a problem hiding this comment.
Yeah, this is very annoying
|
I may not have time to do a test run this weekends so I will not initiate merging. Varun, please merge it yourself after test and when you think it is ready. |
No worries, thanks again for the review :D |
pulsejet
added a commit
that referenced
this pull request
Dec 24, 2024
Rework face API and fix transports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace #66