Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download of wildcard certificates is not working #78

Open
kimselius opened this issue Feb 18, 2018 · 1 comment
Open

Download of wildcard certificates is not working #78

kimselius opened this issue Feb 18, 2018 · 1 comment

Comments

@kimselius
Copy link

When a wildcard certificate is downloaded (i.e. *.example.com) all files that are zipped in the zip archive are named *.example.com.crt, etc.

Since Windows is not able to handle * in the filename, the zipfile appears to be empty.

I fixed this by adding the following code on line 2678 of modules/servers/namecheapssl/namecheapssl.php:
$commonName = str_replace("*", "__", $commonName);

Will this be fixed in upcoming releases?

@innovahost
Copy link

@kimselius Thanks for this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants