fix: check if request from db is 0 before dividing

nais · Jul 5, 2024 · fbec99b · fbec99b
1 parent 40c4751
commit fbec99b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/internal/database/gensql/resourceusage.sql.go b/internal/database/gensql/resourceusage.sql.go
diff --git a/internal/database/queries/resourceusage.sql b/internal/database/queries/resourceusage.sql
@@ -62,8 +62,8 @@ ORDER BY
 -- ResourceUtilizationForTeam will return resource utilization records for a given team.
 -- name: ResourceUtilizationForTeam :many
 SELECT
-    COALESCE(SUM(usage),0)::double precision AS usage,
-    COALESCE(SUM(request),0)::double precision AS request,
+    SUM(usage)::double precision AS usage,
+    SUM(request)::double precision AS request,
     timestamp
 FROM
     resource_utilization_metrics

diff --git a/internal/resourceusage/client.go b/internal/resourceusage/client.go
@@ -236,6 +236,9 @@ func (c *client) ResourceUtilizationTrendForTeam(ctx context.Context, team slug.
 	if err != nil {
 		return nil, err
 	}
+	if cpuAverage.Request == 0 || memoryAverage.Request == 0 {
+		return nil, nil
+	}
 
 	averageCpuUtilization := cpuAverage.Usage / cpuAverage.Request * 100
 	averageMemoryUtilization := memoryAverage.Usage / memoryAverage.Request * 100