Add support for GA4 #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using jinja2 whitespace control.
|
Johan Guldmyr ***@***.***>
aliandika:
Hello! Thanks for an awesome looking theme!
Hi Johan!
I think this is needed. Haven't fully tested it but at least it looks like I want it now with the indentation :)
Not sure about the name of the different analytics.
The script that google wanted me to add was quite different looking from what was in here before. I think the old style is being sunset/has already been. So maybe it'd make more sense to drop support for the old non-GA4 stuff?
Thanks for this patch! I haven't had the
bandwidth to look at this nor test it. Over this
coming weekend I'll review this and if things look
good, I'll go ahead and merge this PR. Thanks for
the contrib \m/\m/.
…--
(Life is like a pencil that will surely run out,
but will leave the beautiful writing of life.)
(D4F09EB110177E03C28E2FE1F5BBAE1E0392253F
(hkp://keys.openpgp.org))
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Thanks for an awesome looking theme!
I think this is needed. Haven't fully tested it but at least it looks like I want it now with the indentation :)
Not sure about the name of the different analytics.
The script that google wanted me to add was quite different looking from what was in here before. I think the old style is being sunset/has already been. So maybe it'd make more sense to drop support for the old non-GA4 stuff?