From 6a0c989c758fafcb95734d69caed042523352b51 Mon Sep 17 00:00:00 2001
From: Tian <tian@dydx.exchange>
Date: Fri, 21 Jun 2024 16:08:29 -0400
Subject: [PATCH] feat(new market): have other market validation run on diff
 only (#705)

---
 .../workflows/validate-other-market-data.yml  |  7 ++
 scripts/validate-other-market-data.ts         | 66 ++++++++++++++++++-
 2 files changed, 71 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/validate-other-market-data.yml b/.github/workflows/validate-other-market-data.yml
index 27adcab26..dfed16ed7 100644
--- a/.github/workflows/validate-other-market-data.yml
+++ b/.github/workflows/validate-other-market-data.yml
@@ -48,6 +48,13 @@ jobs:
           make build
           echo "Starting localnet..."
           DOCKER_BUILDKIT=1 make localnet-startd
+
+      - name: Get diff of otherMarketData.json
+        run: |
+          git fetch origin
+          git diff remotes/origin/main -- public/configs/otherMarketData.json > otherMarketDiff.txt
       
       - name: Validate other market data
+        env:
+          DIFF: otherMarketDiff.txt
         run: pnpx tsx scripts/validate-other-market-data.ts
diff --git a/scripts/validate-other-market-data.ts b/scripts/validate-other-market-data.ts
index 23cd11ff9..05db57cba 100644
--- a/scripts/validate-other-market-data.ts
+++ b/scripts/validate-other-market-data.ts
@@ -752,10 +752,70 @@ async function retry<T>(
   }
 }
 
+// getMarketsToValidate finds markets that are either added or modified.
+function getMarketsToValidate(otherMarketsContent: string): Set<string> {
+  const diffFile = process.env.DIFF;
+  if (!diffFile) {
+    throw new Error('Diff file does not exist');
+  }
+
+  // Get added/modified line numbers.
+  const diffContent = readFileSync(diffFile, 'utf8');
+  const diffLines = diffContent.split('\n');
+  const changedLines: number[] = [];
+  let currentLine = 0;
+  diffLines.forEach(line => {
+    if (line.startsWith('@@')) {
+      const match = line.match(/@@ \-(\d+),\d+ \+(\d+),\d+ @@/);
+      if (match) {
+        currentLine = parseInt(match[2], 10) - 1;
+      }
+    } else if (line.startsWith('+') && !line.startsWith('+++')) {
+      currentLine += 1; 
+      changedLines.push(currentLine);
+    } else if (!line.startsWith('-')) {
+      currentLine += 1;
+    }
+  });
+
+  // Get all added/modified markets.
+  const marketsToValidate = new Set<string>();
+  const lines = otherMarketsContent.split('\n');
+  const findMarket = (lineNumber: number, lines: string[]) => {
+    for (let i = lineNumber - 1; i >= 0; i--) {
+      const line = lines[i].trim();
+      const match = line.match(/"([A-Z]+)": \{/);
+      if (match) {
+        return match[1];
+      }
+    }
+    return null;
+  };
+  changedLines.forEach(line => {
+    const market = findMarket(line, lines);
+    if (market) {
+      marketsToValidate.add(market);
+    }
+  });
+  if (marketsToValidate.size === 0) {
+    console.log('No markets to validate');
+  }
+
+  return marketsToValidate;
+}
+
 async function main(): Promise<void> {
-  // Read proposals from json file.
+  // Get markets to validate.
   const fileContent = readFileSync(PATH_TO_PROPOSALS, 'utf8');
-  const proposals: Proposal[] = Object.values(JSON.parse(fileContent));
+  const marketsToValidate = getMarketsToValidate(fileContent);
+  console.log("\nValidating markets: ", marketsToValidate);
+  if (marketsToValidate.size === 0) {
+    return;
+  }
+
+  // Extract proposals.
+  const allMarkets = JSON.parse(fileContent)
+  const proposals: Proposal[] = Array.from(marketsToValidate).map(market => allMarkets[market]);
 
   // Validate JSON schema.
   console.log('Validating JSON schema of params...\n');
@@ -773,6 +833,8 @@ async function main(): Promise<void> {
   // Validate proposals against localnet.
   console.log('\nTesting proposals against localnet...\n');
   await validateAgainstLocalnet(proposals);
+
+  console.log(`\nValidated ${proposals.length} markets. See log for specific names.`);
 }
 
 main()