API: filtering by timespan

[myxor]

The API should be able to filter by timespans

[Funatiker]

First of all, thank you so much for this project!

If I may make a remark, then I would appreciate if more information on times was stored in log. Currently, lastStateChange is stored in vehicles. Shouldn't it be stored in log? A parking vehicle marks then probably the end of a ride since lastStateChange. If there are two log entries with slightly different GPS coordinates but the same lastStateChange, then this is probably not a trip (that would appear on the heatmap of #1 ) but drifting GPS coordinate. Additionally, log could store last timestamp when the log was received from the server. This could be an approximation of the begin of the next trip.

[myxor]

First of all, thank you so much for this project!

You are welcome. Thank you for supporting this.

If I may make a remark, then I would appreciate if more information on times was stored in log. Currently, lastStateChange is stored in vehicles. Shouldn't it be stored in log? A parking vehicle marks then probably the end of a ride since lastStateChange.

As the TIER API is not documented i am not quite sure what kind of state-change this value represents. It could be driving/resting or rented/free or powered on/powered off or some other state.

Before moving this column to the log table i would suggest we should find out what kind of state this value repesents (probably easiest way is to really rent a scooter and see what happens with this value on the matching vehicle).

Additionally, log could store last timestamp when the log was received from the server. This could be an approximation of the begin of the next trip.

The column timestamp in the table log is filled with the current UTC timestamp when the row is inserted. See log.py#L109.
@Funatiker Is this what you are talking about?

[Funatiker]

The column timestamp in the table log is filled with the current UTC timestamp when the row is inserted. See log.py#L109.
@Funatiker Is this what you are talking about?
Almost! A line is only reinserted/updated when the location, the battery level or the 30-min-timegrame has changed.

TierScooterAnalysis/log.py

Line 125 in 3846320

query = "SELECT internal_id FROM log WHERE internal_id = ? AND timestamp > ? AND lat = ? AND lng = ? AND batteryLevel = ? AND state = ? ORDER BY timestamp DESC LIMIT 1"

This means that the timestamp you mentioned only stores when the log has first been touched but not when it has been touched for the last time. Or with other words: From the currently stored data, we can't tell the difference whether a scooter that has been logged at 11:51 has disappeared at 11:52 or at 12:26 if we see it a again at 12:27.

[myxor]

Now i got you.
Wouldn't it be better then to fill a new column called lastSeen or similar in the vehicle table with the timestamp?

[Funatiker]

Ah. Sorry for having been unclear. I did mean storing an additional column with the lastSeen value.

About the other remark, the state change timestamp: From observing vehicles around me, I got the impression that the timestamp is updated when the vehicle gets (de)activated. The last rental/return time does not seem to be exposed directly by the API.

[myxor]

Ah. Sorry for having been unclear. I did mean storing an additional column with the lastSeen value.

I can see the usage of this value.
Feel free to implement this and send a pull request so i can merge it :)

From observing vehicles around me, I got the impression that the timestamp is updated when the vehicle gets (de)activated. The last rental/return time does not seem to be exposed directly by the API.

Thanks for finding this. Good to know.
Let's see if we can use this information for this project somehow.