Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible character encoding problem in 2.2 #1905

Closed
jonkri opened this issue Nov 14, 2017 · 2 comments
Closed

Possible character encoding problem in 2.2 #1905

jonkri opened this issue Nov 14, 2017 · 2 comments

Comments

@jonkri
Copy link
Contributor

jonkri commented Nov 14, 2017

When I'm visiting https://fixamingata.se/around?js=1&pc=orust, the hits are displayed with the appropriate national characters: "Orust, Västra Götalands län, Götaland, Sverige".

However, when I visit the same page on our beta site (https://fixamingata.se/around?js=1&pc=orust, based on HEAD) the hit is shown as "Orust, Västra Götalands län, Götaland, Sverige".

Has something changed in regard to this lately?

I reverted my changes in https://github.com/jonkri/fixmystreet/commit/7ed9770031b20b304722ffa50850c97bc476307f, but the problem still occurred.

Thanks!

@dracos
Copy link
Member

dracos commented Nov 14, 2017

The display of results from the geocoder was broken in 5934b38, part of #1871 – because I did not know about a bug in HTTP::Message, libwww-perl/HTTP-Message#72 (originally reported in 2013; I've submitted a PR at libwww-perl/HTTP-Message#90). I've submitted a PR at #1906 that hopefully fixes this. Note that double-encoded data will have been saved in the cache, so that will need clearing too once the fix is deployed.

@jonkri
Copy link
Contributor Author

jonkri commented Nov 16, 2017

Wonderful, it works now, thank you. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants