From 61024f135bbf4897ae46e9c6f667715dfa62d340 Mon Sep 17 00:00:00 2001 From: Fritz Duchardt Date: Fri, 29 Dec 2023 11:44:45 +0100 Subject: [PATCH 1/2] Commands are logged after executing. Current wording is misleading. --- internal/myks/util.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/myks/util.go b/internal/myks/util.go index ca941ac5..977ac344 100644 --- a/internal/myks/util.go +++ b/internal/myks/util.go @@ -273,9 +273,9 @@ func runCmd(name string, stdin io.Reader, args []string, logFn func(name string, func msgRunCmd(purpose string, cmd string, args []string) string { msg := cmd + " " + strings.Join(reductSecrets(args), " ") if purpose == "" { - return "Running \u001B[34m" + cmd + "\u001B[0m\n\u001B[37m" + msg + "\u001B[0m" + return "Ran \u001B[34m" + cmd + "\u001B[0m\n\u001B[37m" + msg + "\u001B[0m" } else { - return "Running \u001B[34m" + cmd + "\u001B[0m to: \u001B[3m" + purpose + "\u001B[0m\n\u001B[37m" + msg + "\u001B[0m" + return "Ran \u001B[34m" + cmd + "\u001B[0m to: \u001B[3m" + purpose + "\u001B[0m\n\u001B[37m" + msg + "\u001B[0m" } } From cef1ce5bd5d74da54caa86e7b4f1f9ede3374eb6 Mon Sep 17 00:00:00 2001 From: Fritz Duchardt Date: Fri, 29 Dec 2023 11:45:10 +0100 Subject: [PATCH 2/2] Corrected log message for plugin execution failure --- cmd/plugin.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/plugin.go b/cmd/plugin.go index 7c4a1c3f..410ed672 100644 --- a/cmd/plugin.go +++ b/cmd/plugin.go @@ -73,7 +73,7 @@ func newPluginCmd(plugin myks.Plugin) *cobra.Command { } if err := g.ExecPlugin(asyncLevel, plugin, pluginArgs); err != nil { - log.Fatal().Err(err).Msg("Unable to render applications") + log.Fatal().Err(err).Msg("Plugin did not run successfully") return err }