Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Support for local helm charts #194

Closed
fritzduchardt opened this issue Dec 29, 2023 · 4 comments
Closed

[feature] Support for local helm charts #194

fritzduchardt opened this issue Dec 29, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@fritzduchardt
Copy link
Collaborator

While using ytt is great, it is not as well known as helm and in some cases sticking to helm reduces complexity and makes it easier to introduce myks. Therefore, we could introduce a new folder type in prototypes that contains local charts, e.g.:

prototypes:
  my-app:
    helm
    vendir
    ytt
    **chart**

The chart folder would contain a local helm chart in the standard format:

chart:
  templates
  Chart.yaml
  Chart.lock
  values.yaml

When rendering, the local charts would be templated and added to the remote chart (if there is one).

@fritzduchardt fritzduchardt added the enhancement New feature or request label Dec 29, 2023
@Zebradil
Copy link
Member

What about having local charts in a shared space? The example can be placed in repo/charts/my-app in the repository root (repo probably should be named differently).

With the following vendir config (when #191 gets merged):

apiVersion: vendir.k14s.io/v1alpha1
kind: Config
directories:
- path: charts/my-app
  contents:
  - path: .
    directory:
      path: repo/charts/my-app

I believe that complex prototypes should reside outside of the myks configuration tree. They should probably have their own life cycle. They will be also more reusable when they reside outside of myks' prototypes directory — they can be even used on their own! :-)

@fritzduchardt
Copy link
Collaborator Author

What I am aiming for is a simplification. Some potential users of myks might appreciate it. Consider a setup where you use external secrets to extract secrets from Vault and put them into the cluster. With that you have plenty of split deployments that consist of one app for the application and a tiny one for the secrets. If now the team feels shy to use ytt, because they are struggling to digest the rest of the setup, having a local chart would be the next best thing.

@Zebradil
Copy link
Member

Zebradil commented Jan 1, 2024

Consider a setup where you use external secrets to extract secrets from Vault and put them into the cluster. With that you have plenty of split deployments that consist of one app for the application and a tiny one for the secrets.

Sorry, I'm not familiar with the external secrets. What do you mean by "split deployments"? Why there would be "a tiny one for the secrets"?

Could you also address this question?

@fritzduchardt
Copy link
Collaborator Author

After discussion I agree that the case for this feature is not quite as compelling as I though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants