New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More subscriptions than permitted by PB_NATS_CLIENT_SUBSCRIPTION_POOL_SIZE #1

Open

film42 opened this issue Jan 4, 2023 · 1 comment

Contributor

film42 commented Jan 4, 2023

https://github.com/mxenabled/protobuf-nats/blob/master/lib/protobuf/nats/client.rb#L18

Despite a firm limit on subscriptions at 512, we're seeing more than 2k connections.

Saw this opened here but I believe this bug is related to this gem: mperham/connection_pool#170

It's possible subscriptions are leaking out here: https://github.com/abrandoned/protobuf-nats/blob/84d632feb39684358b39727a4d5689c2545d3589/lib/protobuf/nats/client.rb#L245-L248

However, we should rewrite this implementation to use a single subscription like the official request method of the nats libraries.

Contributor Author

film42 commented Jan 5, 2023

Spiked out an impl here: #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment