Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MicroLIA classifier #13

Open
1 of 4 tasks
wmwv opened this issue Jul 7, 2023 · 4 comments
Open
1 of 4 tasks

Add MicroLIA classifier #13

wmwv opened this issue Jul 7, 2023 · 4 comments
Assignees

Comments

@wmwv
Copy link
Contributor

wmwv commented Jul 7, 2023

Add microLIA micro-lensing classifier

https://github.com/Professor-G/MicroLIA

  1. Generalize code to support multiple classifiers
  2. Add MicroLIA as one of those classifiers
  3. Create training set file to store for MicroLIA
  4. Test
@wmwv wmwv self-assigned this Jul 7, 2023
@wmwv
Copy link
Contributor Author

wmwv commented Jul 7, 2023

@troyraen
Should "-classifier-" in this cloudbuild line be instead "-supernnova-" or "-microlia-"?

https://github.com/mwvgroup/pittgoogle-user/blob/main/classifier/cloudbuild.yaml#L16

@troyraen
Copy link
Contributor

troyraen commented Jul 7, 2023

That variable, _MODULE_NAME, needs to be the same as the module_name variable in the setup.sh script. The setup.sh script sends the variable in as an argument. So the line you pointed to in cloudbuild.yaml is a default value that doesn't actually get used.

So my vote is probably to leave it as "-classifier-", unless there's something even more general we want to replace it with.

@troyraen
Copy link
Contributor

troyraen commented Jul 7, 2023

(I think that a default value has to be defined. But if I'm remember that wrong and it's not actually required, it might be better to just take that line out.)

@wmwv
Copy link
Contributor Author

wmwv commented Jul 8, 2023

Thank you. That is most helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants