Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Incorrect redshift for models. #24

Open
djperrefort opened this issue Aug 21, 2019 · 1 comment
Open

Incorrect redshift for models. #24

djperrefort opened this issue Aug 21, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@djperrefort
Copy link
Member

The fluxes we are using to define each custom model are simulated at a distance of 1 kpc away. However, sncosmo asserts a default redshift of 0 for each instantiated Model class. Technically this isn't a big deal because 1 kpc is a pretty small redshift:

>>> from astropy import units as u
>>> from astropy.cosmology import WMAP9
>>> from astropy.coordinates import Distance
>>>
>>> d = Distance(value=1, unit=u.kpc)
>>> d.compute_z(WMAP9)
2.3120594343144655e-07

However, I would still prefer us porting the model correctly.

@djperrefort djperrefort added the bug Something isn't working label Aug 22, 2019
@djperrefort
Copy link
Member Author

More information on setting custom redshifts for a source and the resulting effect at: sncosmo/sncosmo#249

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant