-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ignore_comments
not default (next major release)
#74
Labels
Comments
This was referenced Apr 5, 2020
As a way to address
I think it might be good to always try to
This way
|
mverleg
added a commit
that referenced
this issue
Nov 4, 2022
Released v3.16.1 with this optimization, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Stripping comments from files that are multiple megabytes takes an obscene amount of time, even if there are no comments.
I don't think I can make it much faster without writing a whole json parser (in something other than Python, or it can never compete).
So I'm thinking of something like:
ignore_comments=False
the defaultignore_comments
is used to overrideignore_comments
is used to overrideignore_comments
is used to overrideThe text was updated successfully, but these errors were encountered: