Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Navigation menu lists all possible modules not just enabled ones #1494

Open
mosen opened this issue Dec 20, 2022 · 3 comments
Open

WIP: Navigation menu lists all possible modules not just enabled ones #1494

mosen opened this issue Dec 20, 2022 · 3 comments
Labels
beta This issue only exists in beta versions bug

Comments

@mosen
Copy link
Contributor

mosen commented Dec 20, 2022

The navigation needs to respect the modules env var and or enabled modules list

@mosen mosen added bug beta This issue only exists in beta versions labels Dec 20, 2022
@mosen
Copy link
Contributor Author

mosen commented Dec 20, 2022

The issue mainly resides with the ModuleServiceProvider which calls loadInfo(true) to make sure that migrations, factories and views are loaded even for disabled modules. I do not recall why they needed to be force loaded, but the 1st parameter of loadInfo is the $allModules param which MR 5.6 uses to force load all modules but only in the context of module marketplace, locales, and widget gallery.

@mosen
Copy link
Contributor Author

mosen commented Dec 20, 2022

I believe i just wanted to load everything up front and control visibility from the Modules class instead of the loading function

@tuxudo
Copy link
Contributor

tuxudo commented Dec 20, 2022

I think the loadInfo(true) is used to force all the modules to load so that the Widget Gallery shows all the widgets with their localization and potential data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta This issue only exists in beta versions bug
Projects
None yet
Development

No branches or pull requests

2 participants