-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elrond Documentation improvements suggestions #408
Comments
I love the erdjs cookbook, it would be great to also include sections about the additional packages like walletcore or the signing providers as well :) |
Maybe add links more walk-through videos (official or from community) |
A docker container with all the library needed to interact with Elrond BC (in python) + rust to build SC could be awesome to me, a ready to code in 2 minutes for new builder. I made myself a tiny docker file (some command must be run manually), but providing something official could be nice : FROM python:3.9
RUN apt update && apt --yes --force-yes install wget unzip build-essential python python-dev virtualenv libncurses5 sudo
RUN useradd -m elrond && echo "elrond:elrond" | chpasswd && adduser elrond sudo
RUN echo 'elrond ALL=(ALL) NOPASSWD: ALL' >> /etc/sudoers
USER elrond
WORKDIR '/home/elrond/'
RUN echo "alias ll='ls -lah'" >> /home/elrond/.bashrc
RUN echo "PATH=$PATH:/home/elrond/.local/bin" >> /home/elrond/.bashrc
RUN wget -O erdpy-up.py https://raw.githubusercontent.com/ElrondNetwork/elrond-sdk-erdpy/master/erdpy-up.py
RUN python3.9 erdpy-up.py
# Install rust
RUN curl https://sh.rustup.rs -sSf | sh
RUN echo "source $HOME/.cargo/env" >> /home/elrond/.bashrc
# used by profiler "erdpy contract report"
RUN erdpy deps install twiggy
CMD /bin/bash
Page to complete : https://docs.elrond.com/validators/mainnet/use-docker/ Edit : I found this container image in the official docker hub : https://hub.docker.com/r/elrondnetwork/elrond-sdk-erdpy-rust may be it already do the job but at least we could add it in the documentation as fallback for people who want to use |
Some suggetions:
|
In the ESDT tokens docs, there is a good explication to know how to issue, set local roles, and mint tokens via built-in functions, but there is a lack of explanation of how to do the same thing in an SC. So it would be nice to have code snippets and explanations for :
PS: Same thing for the NFT Tokens docs. |
Maybe extract the 'developers' section from the docs to a separate service (ex. developers.elrond.com) where it could be better organized with a clear separation of the dapp building blocks and smart contracts building blocks. With the common ground in the form of up-to-date simple, mid, and more advanced tutorials. It would also be nice to have a UX specialist who could design such a website. Good design would also be great because it will catch attention at the first interaction with the website. Also, in the erdjs cookbook, there are code blocks without broader context, which can be confusing for beginners. Missing imports, some not explained assumptions, etc. Having links to the repositories from where these code blocks are copied would be perfect. I would also love to see a very minimal example of a Rust testing framework configuration and tests, without any 'wrappers', abstractions, without Mandos generation, etc, just essential stuff on a simple smart contract, like the 'adder'. Plus some general info about Mandos <> Rust testing framework relation (what, when, why should be used). All in one section. Keeping all up to date will be challenging but crucial. It could probably be one of the todo points in each tool version release. |
A more complete and organized documentation for testing of SCs. Maybe we have a Testing section under the Developers part of the docs where all things SC testing are explained in-depth. From setting up and updating a local-testnet (updating the nodes, proxies, etc to user specified version; testnet.toml structure and options in it to setup the configs the proxies, observers and other components of the testnet), then the rust testing framework, then the two flavours of Mandos test (go and rust)... |
It would be great to have:
|
The big picture regarding all available APIs + their specifics.
In its simplest form, it could look like a table:
Almost every documentation part should firstly clearly emphasize the purpose. Document all common impediments + common Q&As on StackOverflow: Add examples for the trivial interesting API calls.
|
I've tried https://hub.docker.com/r/elrondnetwork/elrond-sdk-erdpy-rust this image use an old version of erdpy If you need I've created this image https://hub.docker.com/r/system1337/erdpy I will try to keep it up to date |
Hi, thanks for your contribution. Examples for signing providers are already available here:
|
I would like to have documentation on meta-transactions because there is no documentation on how to implement MT in a project, the only theoretical documentation I could find is here: https://github.com/ElrondNetwork/elrond-specs/blob/main/sc-meta-transactions.md So if you can do some documentation on how to handle relayed tx and things around that, that would be great (it can be super useful for play-to-earn and other simple games) |
For the beginners it will be great if the method parameters will have more detailed explanations about what they mean, how to get them and what conversions are necessary for them to be properly set. Also basic usage examples will be very nice. I am a Unity developer and not all developers have a web development background and it is hard for them to navigate through that dapp provided as example because most of the functionality is hidded inside 3rd party libraries. I am making this on my own for other Unity developers out there and I try to make it for dummies with usage examples Maybe for the basic functionalities, like login, sign transactions, send tokens, send NFTs, interact with smart contracts, calling smart contracts methods, create tokens, mint nfts, multisig wallets that most developers need for their dApp some examples for dummies might help. Thank you! |
Hello community, I like Julian's suggestion of having specialized areas of focus pages dedicated to development. I would express the following suggestions:
Thank you! |
Hello @SergiViP, I just made a video on this. Please check on my channel and see if it helps. |
Hello @phouverneyuff, Please check out my videos and let me know if this was helpful towards your intrests in MSC Contracts. The first video in this series also tests "adding a boardmember" to the MSC which in a way is upgrading a smart contracts. https://www.youtube.com/playlist?list=PLhGQKpg9cBtjy8yqrbtMqhW9t8cRk8hrd |
Hello @chainofindustry, Please check out my channel and let me know if you find these videos helpful: |
Hello! As an update, many of the items described in this issue were solved. You can follow the PRs activity here: |
Maybe a bit of documentation for the herotag/dns system would be nice :) Currently there is nothing in the docs about it. |
I think we need some more clarification and refresh on the 'Tokens' section. I think the best would be to split all the types into separate sections (EGLD, Fungible ESDT, Non-fungible ESDT, Semi-fungible ESDT, Meta ESDT), even if we need to copy some content in each section. Or at least indicate that some functions are the same in each section but from within the section, not on some other page. This way, developers are sure that they have complete documentation on one topic and don't have to switch pages. Also, some built-in functions need to be clarified—for example, burn/mint functionality for different token types. |
This issue is open so new feedback or suggestions are written in the comments.
Please write in the comments any relevant improvements suggestions. These can include lack of documentation in some areas, things that one tried to do but didn't find any documentation about, and so on.
The text was updated successfully, but these errors were encountered: